Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached store part #2: implementation #458

Open
wants to merge 2 commits into
base: leb-cached-1
Choose a base branch
from
Open

Cached store part #2: implementation #458

wants to merge 2 commits into from

Conversation

levb
Copy link
Contributor

@levb levb commented Feb 19, 2023

No description provided.

@levb levb added the 2: Dev Review Requires review by a core committer label Feb 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023 •
edited
Loading

Codecov Report

Base: 20.88% // Head: 23.12% // Increases project coverage by +2.24% 🎉

Coverage data is based on head (4692f04) compared to base (061a175).
Patch coverage: 31.98% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           leb-cached-1     #458      +/-   ##
================================================
+ Coverage         20.88%   23.12%   +2.24%     
================================================
  Files                79       85       +6     
  Lines              5416     5638     +222     
================================================
+ Hits               1131     1304     +173     
- Misses             4153     4183      +30     
- Partials            132      151      +19
Impacted Files Coverage Δ
apps/app.go 0.00% <0.00%> (ø)
apps/manifest.go 91.17% <0.00%> (-2.77%) ⬇️
server/config/config.go 37.50% <ø> (ø)
server/config/service.go 0.00% <0.00%> (ø)
server/config/test_service.go 0.00% <0.00%> (ø)
server/proxy/invoke_oauth2.go 0.00% <0.00%> (ø)
server/proxy/notify.go 0.00% <0.00%> (ø)
server/proxy/synchronize.go 0.00% <0.00%> (ø)
server/proxy/update_app_listing.go 29.62% <0.00%> (ø)
server/store/appkv.go 0.00% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@levb levb mentioned this pull request Feb 19, 2023
Closed
8 tasks
@hanzei hanzei mentioned this pull request Feb 21, 2023
Merged
@hanzei hanzei added this to the v1.3.0 milestone Feb 21, 2023
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Lifecycle/1:stale
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@levb @codecov-commenter @mattermost-build @hanzei